Fix nuget string representation - #64
Merged
Merged
Conversation
pombredanne
approved these changes
May 2, 2022
pombredanne
left a comment
pombredanne
left a comment
Member
There was a problem hiding this comment.
LGTM... with just a tiny nit as I prefer to keep one import per line.
Please apply and merge!
|
|
||
| from univers.version_constraint import VersionConstraint | ||
| from univers.version_range import GemVersionRange | ||
| from univers.version_range import GemVersionRange, NugetVersionRange |
Member
There was a problem hiding this comment.
Suggested change
| from univers.version_range import GemVersionRange, NugetVersionRange | |
| from univers.version_range import GemVersionRange | |
| from univers.version_range import NugetVersionRange |
| from univers.version_range import NpmVersionRange | ||
| from univers.version_range import OpensslVersionRange | ||
| from univers.versions import PypiVersion | ||
| from univers.versions import NugetVersion, PypiVersion |
Member
There was a problem hiding this comment.
Suggested change
| from univers.versions import NugetVersion, PypiVersion | |
| from univers.versions import NugetVersion | |
| from univers.versions import PypiVersion |
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
keshav-space
pushed a commit
that referenced
this pull request
Aug 30, 2023
Add docs option in configure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com